Skip to content

feat(amazonq): add inline completion support for abap language #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

feat(amazonq): add inline completion support for abap language #7303

merged 6 commits into from
May 14, 2025

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented May 14, 2025

Problem

Solution

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented May 14, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review May 14, 2025 20:09
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners May 14, 2025 20:09
Will-ShaoHua
Will-ShaoHua commented May 14, 2025
View reviewed changes
packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts
'jsx',
'kotlin',
'php',
'plaintext',
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is tested here
https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts#L51

Will-ShaoHua
Will-ShaoHua commented May 14, 2025
View reviewed changes
packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts
['jsx', 'jsx'],
['kotlin', 'kt'],
['php', 'php'],
['plaintext', 'txt'],
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is tested here
https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts#L106

Will-ShaoHua
Will-ShaoHua commented May 14, 2025
View reviewed changes
packages/core/src/codewhisperer/util/runtimeLanguageContext.ts

constructor() {
this.supportedLanguageMap = createConstantMap<
CodeWhispererConstants.PlatformLanguageId | CodewhispererLanguage,
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plaintext is not supported by cwspr, so it doesn't make sense to put it here

@Will-ShaoHua Will-ShaoHua requested a review from justinmk3 May 14, 2025 20:53
@leigaol leigaol merged commit 6fead6e into aws:master May 14, 2025
26 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the lang branch May 15, 2025 18:12
Will-ShaoHua added a commit to Will-ShaoHua/aws-toolkit-vscode that referenced this pull request May 15, 2025
@Will-ShaoHua
Revert "feat(amazonq): add inline completion support for abap language (
7faa3ec 
aws#7303)"

This reverts commit 6fead6e.
@Will-ShaoHua Will-ShaoHua mentioned this pull request May 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmk3 justinmk3 Awaiting requested review from justinmk3

1 more reviewer

@leigaol leigaol leigaol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Will-ShaoHua @justinmk3 @leigaol